Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable suppressing outputs #849

Open
samox73 opened this issue Jan 20, 2023 · 3 comments
Open

Enable suppressing outputs #849

samox73 opened this issue Jan 20, 2023 · 3 comments
Labels
help-wanted We'd love your contributions on this issue impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features

Comments

@samox73
Copy link

samox73 commented Jan 20, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently, when comment-on-pr is set to true and the stack outputs objects, the output is also shown in the comment on the PR. This pollutes the diff view which resources will be changed. It would be helpful to have a flag (similar to the pulumi CLI) to disable printing the outputs.

Affected area/feature

@samox73 samox73 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jan 20, 2023
@dixler dixler added help-wanted We'd love your contributions on this issue impact/usability Something that impacts users' ability to use the product easily and intuitively and removed needs-triage Needs attention from the triage team labels Jan 20, 2023
@dixler
Copy link
Contributor

dixler commented Jan 20, 2023

Hi. This sounds like a nice addition. Do you think you could put an example of a normal comment and what the desired comment would look like just for clarity?

This isn't on our roadmap, but we would be willing to merge a feature like this if were implemented.

@alexiskat
Copy link

This is my config in Github action

      - name: Preview changes to Infra  🚀
        uses: pulumi/actions@v4
        id: pulumi_review
        with:
          command: preview
          stack-name: ${{ env.PULUMY_DEV_XXXXX }}
          work-dir: ${{ env.PULUMY_DEV_XXXXX }}
          color: always
          diff: true
        env:
          PULUMI_CONFIG_PASSPHRASE: ${{ secrets.PULUMI_INFRA_XXXXX }}

At the moment with this I am getting hit with the issue reported #859 . The output in the PR comment looks like this:
Screenshot 2023-02-23 at 09 16 00

This debugging information goes on for pages. I think its to verbose. At the end it has this:
Screenshot 2023-02-23 at 09 19 58

I could expect that the output in the PR comment would be the same as when you run the preview command in the terminal, to just give you the information about the stack changes and not to include all the python install output as above

@rtrindvg
Copy link

Any updates on this?
Ever since the pulumi/docker v4 update it's not possible anymore to supply extra args to it, which means all the docker build output is shown on the pulumi/actions output on the PR, too verbose. Having the option for the output to be just the equivalent to the regular CLI pulumi preview would help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted We'd love your contributions on this issue impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

4 participants