Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pulumi execution output to README #932

Open
rtrindvg opened this issue May 9, 2023 · 2 comments
Open

Add pulumi execution output to README #932

rtrindvg opened this issue May 9, 2023 · 2 comments
Labels
kind/enhancement Improvements or new features

Comments

@rtrindvg
Copy link

rtrindvg commented May 9, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Today I am using the "comment-on-pr" action attribute to show the "pulumi preview" on each environment before approval/deploy. I am changing my workflow to use an IssueOps style of approval, creating a new Issue for the first deployment to me made, awaiting for a comment approving it, deploying and creating a new issue for the next environment and so on.

For this to work better, it would be nice to output the same content present on the "comment-on-pr" on the actions output sections. This would allow us to use this to enrich the issue with the preview execution, without the need to go to the pull request to check it.

After a brief discussion on the Slack channel it was suggested to open the feature suggestion here. I would gladly try to implement something but in an in the middle of a personal health crisis at this moment and won't be able to tackle this for at least the next 2 weeks. After this, if no PR suggestion is made I will try to address it.

Affected area/feature

Pulumi Actions

@rtrindvg rtrindvg added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels May 9, 2023
@justinvp justinvp removed the needs-triage Needs attention from the triage team label May 12, 2023
@justinvp
Copy link
Member

Thanks for opening the issue and offer to work on it when you can!

@rtrindvg
Copy link
Author

rtrindvg commented May 31, 2023

Actually, when I started working on the code, I noticed the feature is already there, just undocumented. It was implemented in #68.

I will adjust the title of this issue to add this information on the README file, although I would prefer not to open the PR, since I am not a native speaker.

@rtrindvg rtrindvg changed the title Expose pulumi execution as an output Add pulumi execution output the documentation May 31, 2023
@rtrindvg rtrindvg changed the title Add pulumi execution output the documentation Add pulumi execution output to README May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants