Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Pick up version from a versioning file #977

Open
runlevel5 opened this issue Jul 7, 2023 · 1 comment
Open

[Feature Request] Pick up version from a versioning file #977

runlevel5 opened this issue Jul 7, 2023 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@runlevel5
Copy link

I have always been a big fan of the ability to specify a version file to pick up the correct tooling version. Here is one example of actions/setup-node:

- uses: actions/setup-node@v3
     with:
        node-version-file: '.tool-versions'

in the above example, the .tool-versions has:

nodejs 18.16.0

I would like to propose adopting this functionality to make life easier for devs who have been using asdf for picking the right pulumi version, something like this:

- uses: pulumi/actions@v4
      with:
        # pulumi-version: '3.74.0' 
        pulumi-version-file: '.tool-versions'
..

# .tool-versions
pulumi 3.74.0
@runlevel5 runlevel5 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jul 7, 2023
@Frassle Frassle removed the needs-triage Needs attention from the triage team label Jul 7, 2023
@Frassle
Copy link
Member

Frassle commented Jul 7, 2023

I suspect we probably won't support this directly as it looks simple enough to use something like tool-versions-action to do this:

- name: Read .tool-versions
  uses: marocchino/tool-versions-action@v1
  id: versions
- uses: pulumi/actions@v4
    with:
      pulumi-version: $ {{ steps.versions.outputs.pulumi }}

But I'll leave this open to see if there's a good argument or a high demand for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants