Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade workflows create duplicate issues and pull requests #1125

Closed
guineveresaenger opened this issue Nov 4, 2024 · 3 comments
Closed
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@guineveresaenger
Copy link
Contributor

guineveresaenger commented Nov 4, 2024

#1110 seems to have caused an identical issue to be created every time the upgrade workflow runs. When all of the automation succeeds without intervention, this is not a problem. But in cases where the upgrade needs manual assistance, we'll see the same issue created over and over:

Image

If an issue already exists, we should not create another one.

Additionally, if an automated pull request is not merged same-day, an (identical, most likely) new one is opened:

Image

@guineveresaenger guineveresaenger added the kind/bug Some behavior is incorrect or out of spec label Nov 4, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 4, 2024
@guineveresaenger guineveresaenger changed the title Upgrade workflows create duplicate issues Upgrade workflows create duplicate issues and pull requests Nov 4, 2024
@guineveresaenger
Copy link
Contributor Author

More information:

@guineveresaenger
Copy link
Contributor Author

pulumi/pulumi-alicloud#829 on the other hand, closes all 3 identically-named issues.

The main fix here seems to be to not open duplicative issues or pull requests.

@danielrbradley danielrbradley added resolution/fixed This issue was fixed and removed needs-triage Needs attention from the triage team labels Nov 5, 2024
@danielrbradley danielrbradley self-assigned this Nov 5, 2024
@danielrbradley
Copy link
Member

This was an issue in upgrade-provider which was fixed with pulumi/upgrade-provider#287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants