Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-provider automation mistakenly mixes bridge and upstream upgrades #1141

Open
t0yv0 opened this issue Nov 12, 2024 · 0 comments
Open
Labels
kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Nov 12, 2024

Noticed this in pulumi/pulumi-aws#4752

https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/internal/pkg/templates/bridged-provider/.github/workflows/upgrade-provider.yml#L83

The code:

        run: upgrade-provider "${{ github.repository }}" --kind="all" --target-version="${{ steps.target_version.outputs.version }}" #{{ if .Config.javaGenVersion }}#--java-version="#{{ .Config.javaGenVersion }}#"#{{ end }}#

The --kind="all" flag is mixing bridge and upstream upgrades in a single change, which makes it harder to understand where changes are coming from and harder to bisect issues. Would it be possible to scope this to only upstream upgrades? And have a separate workflow handle upgrading the bridge

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 12, 2024
@VenelinMartinov VenelinMartinov added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

3 participants