Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in providers by default #1204

Open
iwahbe opened this issue Dec 9, 2024 · 1 comment
Open

Run tests in providers by default #1204

iwahbe opened this issue Dec 9, 2024 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@iwahbe
Copy link
Member

iwahbe commented Dec 9, 2024

We should run tests in the module rooted in providers by default. In GCP we do it with a pre-test hook. This should be the default.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 9, 2024
@iwahbe iwahbe added kind/enhancement Improvements or new features and removed needs-triage Needs attention from the triage team labels Dec 10, 2024
@blampe
Copy link
Contributor

blampe commented Dec 11, 2024

Some providers currently put unit and integration tests under provider. We should certainly always run those unit tests, however we don't need two places for integration tests. Those should be consolidated somewhere -- typically "examples" but the name doesn't matter and this is configurable. In CDK we moved these to a tests directory.

Having one place for integration tests will simplify sharding and speed things up overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

3 participants