Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make drift in native providers #1236

Open
11 tasks
t0yv0 opened this issue Dec 18, 2024 · 4 comments
Open
11 tasks

Make drift in native providers #1236

t0yv0 opened this issue Dec 18, 2024 · 4 comments
Labels
kind/task Work that's part of an ongoing epic

Comments

@t0yv0
Copy link
Member

t0yv0 commented Dec 18, 2024

Providers

Unlike bridged providers, Native providers do not have Makefile controlled by ci-mgmt, nor do they have a formalized interface that they need to conform to in order to be buildable in a compatible way with the GitHub actions. This opens up possibilities of Makefile being occasionally incompatible and violating the implicit invariants of the actions, causing for example release to succeed with missing SDK files as in pulumi/pulumi-aws-native#1826

We should consider formalizing the interface that native providers makefiles are expected to conform to and unifying them to a shared build system that's tested once and reduces opportunity for error.

Native Providers

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 18, 2024
@guineveresaenger guineveresaenger removed the needs-triage Needs attention from the triage team label Dec 18, 2024
@guineveresaenger
Copy link
Contributor

I'm going to tag @blampe and @danielrbradley on this one.

Related: #1101

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 18, 2024

Yeah we might need to discuss this one. Perhaps worded a bit too fuzzy to execute. The context is in the Postmortem Doc but perhaps there's something concrete we can actually carry out here.

@blampe
Copy link
Contributor

blampe commented Dec 18, 2024

Yeah this is basically #1101 and I'm working towards getting some of these on ci-mgmt.

Related #1131 -- it is very helpful to ship default make targets to providers, but in some circumstances a provider needs to be able to tweak these. E.g. component providers.

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 18, 2024

#1101 was not obvious that it covers this as of yesterday because it seems like aws-native is "already on ci-mgmt" but it still had this custom drifty Makefile problem. But we may include.

@mjeffryes mjeffryes added the kind/task Work that's part of an ongoing epic label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Work that's part of an ongoing epic
Projects
None yet
Development

No branches or pull requests

5 participants