Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated SDK generation @ aws-cloudformation-user-guide 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76 #1908

Closed
wants to merge 3 commits into from

Conversation

pulumi-bot
Copy link
Contributor

Automated PR

Copy link
Contributor

Does the PR have any schema changes?

Found 47 breaking changes:

Resources

  • "aws-native:batch:JobDefinition":
    • inputs:
      • 🟡 "parameters" type changed from "pulumi.json#/Any" to "object":
        • 🟡 additional properties had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
      • 🟡 "tags" type changed from "pulumi.json#/Any" to "object":
        • 🟡 additional properties had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
      • 🟡 "timeout" type changed from "#/types/aws-native:batch:JobDefinitionTimeout" to "#/types/aws-native:batch:JobDefinitionJobTimeout"
    • properties:
      • 🟡 "awsId" missing output "awsId"
      • 🟡 "parameters" type changed from "pulumi.json#/Any" to "object":
        • 🟡 additional properties had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
      • 🟡 "tags" type changed from "pulumi.json#/Any" to "object":
        • 🟡 additional properties had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
      • 🟡 "timeout" type changed from "#/types/aws-native:batch:JobDefinitionTimeout" to "#/types/aws-native:batch:JobDefinitionJobTimeout"
  • "aws-native:cleanrooms:ConfiguredTable":
    • 🟡 inputs: "tableReference" type changed from "#/types/aws-native:cleanrooms:ConfiguredTableTableReference" to ""
    • 🟡 properties: "tableReference" type changed from "#/types/aws-native:cleanrooms:ConfiguredTableTableReference" to ""
  • "aws-native:s3:Bucket":
    • 🟡 inputs: "metadataTableConfiguration" missing
    • 🟡 properties: "metadataTableConfiguration" missing output "metadataTableConfiguration"

Functions

  • "aws-native:batch:getJobDefinition": inputs:
    • 🟡 "id" missing input "id"
    • 🟢 required: "jobDefinitionName" input has changed to Required

Types

  • 🔴 "aws-native:batch:JobDefinitionAuthorizationConfig" missing
  • "aws-native:batch:JobDefinitionContainerProperties": properties:
    • 🟡 "fargatePlatformConfiguration" type changed from "#/types/aws-native:batch:JobDefinitionFargatePlatformConfiguration" to "#/types/aws-native:batch:JobDefinitionContainerPropertiesFargatePlatformConfigurationProperties"
    • 🟡 "instanceType" missing
    • 🟡 "mountPoints": items type changed from "#/types/aws-native:batch:JobDefinitionMountPoints" to "#/types/aws-native:batch:JobDefinitionMountPoint"
    • 🟡 "volumes": items type changed from "#/types/aws-native:batch:JobDefinitionVolumes" to "#/types/aws-native:batch:JobDefinitionVolume"
  • 🟡 "aws-native:batch:JobDefinitionEcsTaskProperties": properties: "volumes": items type changed from "#/types/aws-native:batch:JobDefinitionVolumes" to "#/types/aws-native:batch:JobDefinitionVolume"
  • 🟡 "aws-native:batch:JobDefinitionEfsVolumeConfiguration": properties: "authorizationConfig" type changed from "#/types/aws-native:batch:JobDefinitionAuthorizationConfig" to "#/types/aws-native:batch:JobDefinitionEfsAuthorizationConfig"
  • "aws-native:batch:JobDefinitionEksContainerResourceRequirements": properties:
    • 🟡 "limits" type changed from "pulumi.json#/Any" to "object":
      • 🟡 additional properties had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
    • 🟡 "requests" type changed from "pulumi.json#/Any" to "object":
      • 🟡 additional properties had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
  • 🟡 "aws-native:batch:JobDefinitionEksProperties": properties: "podProperties" type changed from "#/types/aws-native:batch:JobDefinitionPodProperties" to "#/types/aws-native:batch:JobDefinitionEksPodProperties"
  • 🔴 "aws-native:batch:JobDefinitionFargatePlatformConfiguration" missing
  • 🟢 "aws-native:batch:JobDefinitionImagePullSecret": required: "name" property is no longer Required
  • 🟡 "aws-native:batch:JobDefinitionLogConfiguration": properties: "options" type changed from "pulumi.json#/Any" to "object":
    • 🟡 additional properties had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
  • 🔴 "aws-native:batch:JobDefinitionMetadata" missing
  • 🔴 "aws-native:batch:JobDefinitionMountPoints" missing
  • "aws-native:batch:JobDefinitionNodeRangeProperty": properties:
    • 🟡 "container" type changed from "#/types/aws-native:batch:JobDefinitionContainerProperties" to "#/types/aws-native:batch:JobDefinitionMultiNodeContainerProperties"
    • 🟡 "ecsProperties" type changed from "#/types/aws-native:batch:JobDefinitionEcsProperties" to "#/types/aws-native:batch:JobDefinitionMultiNodeEcsProperties"
  • 🔴 "aws-native:batch:JobDefinitionPodProperties" missing
  • 🟡 "aws-native:batch:JobDefinitionTaskContainerProperties": properties: "mountPoints": items type changed from "#/types/aws-native:batch:JobDefinitionMountPoints" to "#/types/aws-native:batch:JobDefinitionMountPoint"
  • 🔴 "aws-native:batch:JobDefinitionTimeout" missing
  • 🔴 "aws-native:batch:JobDefinitionVolumes" missing
  • 🔴 "aws-native:batch:JobDefinitionVolumesHost" missing
  • 🔴 "aws-native:cleanrooms:ConfiguredTableTableReference" missing
  • 🟢 "aws-native:cloudfront:DistributionLogging": required: "bucket" property is no longer Required
  • 🔴 "aws-native:s3:BucketMetadataTableConfiguration" missing
  • 🔴 "aws-native:s3:BucketMetadataTableError" missing
  • 🔴 "aws-native:s3:BucketS3TablesDestination" missing

New resources:

  • logs.Transformer
  • networkmanager.DirectConnectGatewayAttachment

New functions:

  • logs.getTransformer
  • networkmanager.getDirectConnectGatewayAttachment

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.35%. Comparing base (6008c70) to head (745a35e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1908   +/-   ##
=======================================
  Coverage   50.35%   50.35%           
=======================================
  Files          48       48           
  Lines        7000     7000           
=======================================
  Hits         3525     3525           
  Misses       3226     3226           
  Partials      249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0
Copy link
Member

t0yv0 commented Dec 16, 2024

Closing in favor of #1913

@t0yv0 t0yv0 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants