Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace plans dot not explain which property caused a replace #2094

Open
t0yv0 opened this issue Feb 28, 2025 · 2 comments
Open

Replace plans dot not explain which property caused a replace #2094

t0yv0 opened this issue Feb 28, 2025 · 2 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@t0yv0
Copy link
Member

t0yv0 commented Feb 28, 2025

What happened?

This provider uses an interesting strategy for generating replace plans. It never directly returns a replace plan in DiffResult on the gRPC wire:

return &pulumirpc.DiffResponse{

But it does generate SDKs with replaceOnChanges baked in for properties that cause replacement such as:

const replaceOnChanges = { replaceOnChanges: ["clientId", "userPoolId"] };

As a result of this behavior, we get replacement plans as expected, however pulumi preview --diff does not explain which property was causing the replace.

To implement this we would need to extend DiffResponse with Replaces and/or DetailedDiff.

Output of pulumi about

https://github.com/pulumi/pulumi-aws-native/releases/tag/v1.25.0 version affected.

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Feb 28, 2025
@t0yv0
Copy link
Member Author

t0yv0 commented Feb 28, 2025

#1785 may provide more context here or be duplicative @corymhall

@t0yv0 t0yv0 removed the needs-triage Needs attention from the triage team label Feb 28, 2025
@t0yv0
Copy link
Member Author

t0yv0 commented Feb 28, 2025

#1706 also mentions schema recognizers are incomplete.

@t0yv0 t0yv0 changed the title Update plans generated when Replace is required Replace plans dot not explain which property caused a replace Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

1 participant