Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce upstream/go.mod patch churn #4465

Open
t0yv0 opened this issue Sep 16, 2024 · 0 comments
Open

Reduce upstream/go.mod patch churn #4465

t0yv0 opened this issue Sep 16, 2024 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@t0yv0
Copy link
Member

t0yv0 commented Sep 16, 2024

When dependencies change upstream, it often generates patch conflicts over upstream/go.mod. Need to double-check if any modifications are actually necessary. If they are not necessary we can switch to using unmodified upstream/go.mod. If they are indeed necessary we can look at reducing the conflicts by some automation (e.g. automatically apply go mod tidy).
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 16, 2024
@t0yv0 t0yv0 mentioned this issue Sep 16, 2024
Merged
@corymhall corymhall added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@t0yv0 @pulumi-bot @corymhall