Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PageRule docs regarding zone name #24

Closed
clstokes opened this issue Jul 10, 2019 · 3 comments
Closed

Update PageRule docs regarding zone name #24

clstokes opened this issue Jul 10, 2019 · 3 comments
Assignees

Comments

@clstokes
Copy link

As seen in #23, it's unclear that zone for PageRule is actually the zone name (e.g. example.com) and not the zone id.

We should update the docs (or alternatively the property name) to be more clear.

@lukehoban
Copy link

This package is automatically derived from https://github.com/terraform-providers/terraform-provider-cloudflare, so I don't think it would be a good idea to change the property names in our layer - possibly worth suggesting that in the upstream provider - though would be a breaking change there (and here).

@stack72
Copy link
Contributor

stack72 commented Jul 12, 2019

I personally think the documentation needs to be better here - I will submit a fix upstream that makes it more clear that it's the zone name not the ID

@stack72
Copy link
Contributor

stack72 commented Jul 24, 2019

Hi folks, I am going to close this out. It seems there is a change coming down the pipeline that deprecates the use of zone in favour of zone_id

https://github.com/terraform-providers/terraform-provider-cloudflare/pull/421

This will hit soon I believe and will be able to be more explicit about which to use

@stack72 stack72 closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants