Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto-naming to datadog provider #508

Open
VenelinMartinov opened this issue Apr 10, 2024 · 0 comments
Open

Add Auto-naming to datadog provider #508

VenelinMartinov opened this issue Apr 10, 2024 · 0 comments
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Apr 10, 2024

What happened?

Looks like we don't auto-name some (all?) resources in datadog:
#506

All the resource with RandomString names are ones which failed without a name parameter. We handle this for other providers, seems reasonable to do the same for datadog.

Example

name: index_apikeyGrx1Jo4mtRy8
runtime: yaml
description: ""
config:
  pulumi:tags:
    value:
      pulumi:template: https://www.pulumi.com/ai/api/project/cef5cfba-6f6d-4ef1-afac-fe029857cdf5.zip
resources:
  datadogApiKey:
    type: datadog:ApiKey

fails, but succeeds with a name property. Same for:

name: index_logscustompipelineqAzO442RDaIa
runtime: yaml
description: ""
config:
  pulumi:tags:
    value:
      pulumi:template: https://www.pulumi.com/ai/api/project/ffddeb16-4a62-4703-be3a-e13744251a78.zip
resources:
  logs-custom-pipeline:
    properties:
      filters:
        - query: source:python
      isEnabled: true
      processors: []
    type: datadog:LogsCustomPipeline

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Apr 10, 2024
@guineveresaenger guineveresaenger added kind/enhancement Improvements or new features and removed kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Apr 11, 2024
@guineveresaenger guineveresaenger changed the title Auto-naming does not work for datadog resources Add Auto-naming to datadog provider Apr 11, 2024
@guineveresaenger guineveresaenger added the good-first-issue Start here if you'd like to start contributing to Pulumi label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants