Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring multiple node groups as part of the cluster component #1514

Open
bob-bins opened this issue Dec 4, 2024 · 1 comment
Open
Labels
kind/enhancement Improvements or new features

Comments

@bob-bins
Copy link

bob-bins commented Dec 4, 2024

Almost any cluster that runs real workloads will have more than one node group, at which point there's no benefit to using the default node group option because we would have already written our own abstractions for creating node groups. I think this module should expose a param that allows adding multiple node groups instead of just one. Something like:

managedNodeGroups: Record<string, inputs.ClusterNodeGroupOptionsArgs> or Array<inputs.ClusterNodeGroupOptionsArgs>

@bob-bins bob-bins added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Dec 4, 2024
@bob-bins bob-bins changed the title The Cluster's defaultNodeGroup options are not very useful The Cluster's defaultNodeGroup option is not very useful Dec 4, 2024
@flostadler
Copy link
Contributor

Hey @bob-bins, the default node group is mostly geared towards folks starting out with EKS or experimenting and just needing any arbitrary node group.
You're absolutely right that production use cases definitely need more diverse sets of node groups.
Right now you can disable the default node group by setting skipDefaultNodeGroup to true. That way you have full control over which manage/self-managed node groups you create.

I like the idea of adding inputs to the cluster for setting up node groups more easily! I'll track this as a feature request. In case folks are interested in this, please upvote it.

@flostadler flostadler removed the needs-triage Needs attention from the triage team label Dec 5, 2024
@flostadler flostadler changed the title The Cluster's defaultNodeGroup option is not very useful Allow configuring multiple node groups as part of the cluster component Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants