-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManagedNodeGroupOptions doesn't allow SecurityGroup configuration #371
Comments
Thanks for opening the issue, Nima. There is an issue tracking this for EKS in the AWS container roadmap: aws/containers-roadmap#609. Here is more details from AWS:
Here is more details on the differences between managed node groups and self-managed node groups: |
Thanks @metral for the reply. I was thrown off by |
Hello @metral , The referenced dependency issue has been completed a while ago on EKS. Any chance to get this done? Or is there another workaround? (I need to attach custom SGs to nodes to allow private ECR endpoint image pulling.. |
aws/containers-roadmap#609 have done, can we support now? |
This is a blocking feature for a bunch of stuff. Will this be added? |
This is a requirement for Karpenter as it requires to setup additional ingress roles. |
Hi - Any updates about this feature? |
@metral @lukehoban Any updates on this? |
You can set custom security groups via the That being said, we already added a couple of parameters to modify the launch template (e.g. |
Problem description
Looking at the code for creating managed node groups, it looks like the arguments for
ManagedNodeGroupOptions
are derived fromNodeGroupArgs
here which doesn't allow for configuringSecurityGroups
onManagedNodeGroups
or onaws.eks.NodeGroup
. is this intentional?For managed NodeGroups I think it will be helpful to be able to define custom security groups.
Also the behavior seems to be different for
eks.NodeGroups
since throughNodeGroupBaseOptions
the security group on the respective nodes can be configured.The text was updated successfully, but these errors were encountered: