Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests try to upload report to S3 when running locally #621

Closed
alex-hunt-materialize opened this issue Sep 7, 2021 · 0 comments · Fixed by #751
Closed

Tests try to upload report to S3 when running locally #621

alex-hunt-materialize opened this issue Sep 7, 2021 · 0 comments · Fixed by #751
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@alex-hunt-materialize
Copy link
Contributor

External contributors are expected to run the tests with make test, but the tests try to upload results to S3. External contributors do not have credentials to write to the S3 bucket, so the tests should not try to write there when run by external contributors.

Failed to upload test command report to S3: AccessDenied: Access Denied
	status code: 403, request id: ZRXV0269S6VAEAAJ, host id: z9PT2L11ka1uhW0orTQ2maI/oLPLbjWoQfJjSaroAh9AVTeqLfJ1ATLSNls3/vvbYAfLf3LpJqQ=

Steps to reproduce

  1. Export AWS credentials and region for a role/user that doesn't have write permission.
  2. Run make test
  3. See the errors in the logs.

Expected: The tests to run without trying to upload results to S3.
Actual: Failed attempts to upload the test command reports to S3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
3 participants