Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[programgen] generate custom resource options from PCL #546

Closed
Zaid-Ajaj opened this issue May 4, 2022 · 0 comments · Fixed by #558
Closed

[programgen] generate custom resource options from PCL #546

Zaid-Ajaj opened this issue May 4, 2022 · 0 comments · Fixed by #558
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@Zaid-Ajaj
Copy link
Contributor

What happened?

At the moment, programgen ignores custom resource options. it should include it when possible

Steps to reproduce

Compile the following PCL program

resource provider "pulumi:providers:aws" {
	region = "us-west-2"
}

resource bucket1 "aws:s3:Bucket" {
	options {
		provider = provider
		dependsOn = [provider]
		protect = true
	}
}

Expected Behavior

Should generate custom resource options for resources

Actual Behavior

Ignore custom resource options, instead it generates:

public static void stack(Context ctx) {
    var provider = new Provider("provider", ProviderArgs.builder()
        .region("us-west-2")
        .build());

    var bucket1 = new Bucket("bucket1");
}

Versions used

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@Zaid-Ajaj Zaid-Ajaj added the kind/bug Some behavior is incorrect or out of spec label May 4, 2022
@Zaid-Ajaj Zaid-Ajaj self-assigned this May 4, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label May 6, 2022
@mikhailshilkov mikhailshilkov added this to the 0.72 milestone May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants