-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation instructions #419
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
01b5220
to
931a4f9
Compare
931a4f9
to
5f13476
Compare
"Configuring Multiple Tokens", | ||
"Multi-Region Deployments", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should skip these sections? Nomad is a hashicorp service, so I assume folks using this provider may need the instructions for working with vault/consul tokens and different regions?
I bet these break because we don't support converting multiple provider configs in a single hcl example though right? But if that's the reason not to include these sections, maybe we should link to a converter issue in the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not just that. These sections specifically discuss provider aliases and terraform variables in the text which pushed me over the edge of eliding these.
Correcting this would be a fairly heavy lift rewrite, just to show that each region needs their own token, and that you can set Vault and Consul tokens also on different providers. I can do this, but the cost might be that this will break more upgrades. The file itself doesn't see a lot of action over time so this may be worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with just dropping these for now.
"Configuring Multiple Tokens", | ||
"Multi-Region Deployments", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with just dropping these for now.
This PR has been shipped in release v2.4.1. |
Part of pulumi/home#3598
Generates a provider-side
docs/_index.md
file with relevant content.There is an additional text find/replace that is expressed in in
docs/index-md-replaces
, which will fail with a hard error when theinput
text is no longer found upstream.