Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use Pulumi assets & archives in source property of oci.ObjectStorage.StorageObject #561

Open
mikucat0309 opened this issue Aug 11, 2024 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@mikucat0309
Copy link

mikucat0309 commented Aug 11, 2024

Hi all,

We can use the Assets & Archives as the content source for aws.s3.BucketObjectv2, I guess it is also possible to support Assets & Archives in oci.ObjectStorage.StorageObject.

Though I don't know much about how Pulumi works currently, but I willing to learn more about that and try my best to implement this feature.

Any ideas & suggestions are welcome!

@mjeffryes mjeffryes added the kind/enhancement Improvements or new features label Aug 23, 2024
@mjeffryes
Copy link
Member

Thanks for pointing this out and the offer to help @mikucat0309!

I think you are probably right that we can apply the same type coercion that's used on S3 BucketObjectV2 in AWS to make this resource accept Assets and Archives. I believe this is the relevant line in the AWS provider where that is configured; we can do the same thing on StorageObject.source in this repo.

If you do decide to try to dive in for a PR, I suggest using Devbox or the devcontainer to get a build environment that has everything you need to build. make build will rebuild everything and make test will execute all the tests (E2E tests if you add one in the examples folder). There are also some more incremental targets in the Makefile that you can use if you have to iterate on a specific part of the build.

Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants