Panic on use of float64 attributes using SDK v0.9.9 #95
Assignees
Milestone
Comments
|
This sounds like some mismatched bits (across pulumi-terraform, terraform and terraform-provider-aws) in your local environment. I'm going to assume this is not blocking for 0.9.2 unless we see it again, or feel confident you were using a "clean" combination of bits to do this deployment. |
|
I'm fairly confident I don't have mismatched dependencies on my machine. (But feel free to double check this with me.) Here is the output with |
|
Full update log: update-output-1.txt |
|
Alas, Ashley was able to install the service without any problems (building from head), and Matt has been able to do this on a Travis box installing from the SDK. So it does definitely look like a problem with my machine. I'm going to install the v0.9.9 SDK and try again. |
|
If you continue to run into issues please share your complete PATH, and contents of ~/.config/yarn/link (so we can see where all the modules are pointing). |
|
Closing again for now - optimistically assuming this will all work once @chrsmith gets his machine in a sufficiently "clean" state. But feel free to reopen if this remains blocking. |
chrsmith
changed the title
|
Unfortunately I still keep running into this. Which not being able to successfully run Just now I:
I believe I deleted all earlier, older versions of pulumi. This is my current set of Yarn packages: The And |
chrsmith
added
status/needs-info
and removed
kind/bug
|
Looking for other Pulumi packages on the machine:
|
|
Ashley, Me and CI are all running on Linux. Is it possible someone else with a OSX machine can see it they can reproduce this? |
|
I'm able to repro this on my machine (OSX) using the |
mmdriley
changed the title
|
My minimal repro program: import * as aws from "@pulumi/aws";
let s = new aws.cloudwatch.MetricAlarm("abc", {
comparisonOperator: "GreaterThanThreshold",
evaluationPeriods: 1,
metricName: "BucketSizeBytes",
namespace: "AWS/S3",
period: 60,
threshold: 9000,
}); |
|
Support for floats was added somewhat recently (we used to treat all numbers as integers on the Terraform bridge side). It's very interesting that the |
|
Exactly -- it appears to be #88 that exposed this panic, since before that |
|
Dug through the Terraform code to understand what's going on here and how our implementation differs from theirs. Turns out they don't really use The function that Terraform providers use to go from That function ultimately diffs all primitives as strings and returns the new values as strings. Numbers are coerced to strings by calling |
|
Still not confident whether this repros on Linux -- and, if not, why it wouldn't. Hoping @ellismg can chime in running the test program above. |
|
@ellismg verified this repros on Linux. The world makes sense again. @khyperia didn't hit this because her stack didn't set CI hasn't hit this, I suspect, because it hasn't created an alarm since the code to stop truncating |
|
This is fixed, likely as of #104. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Perhaps related to #94, but I got this panic while trying to stand up a new instance of the Pulumi Service stack. (Since @ellismg has been doing this for an automated test, I'm not sure what the problem could be. I'm on v0.9.8. But perhaps my machine has something else going on, as it has been known to do.)
https://github.com/pulumi/pulumi-terraform/blob/master/pkg/tfbridge/schema.go#L379
The text was updated successfully, but these errors were encountered: