Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support granular secretness on invoke result properties #636

Open
mikhailshilkov opened this issue Sep 18, 2024 · 0 comments
Open

Support granular secretness on invoke result properties #636

mikhailshilkov opened this issue Sep 18, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@mikhailshilkov
Copy link
Member

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

When an invoke returns a result with multiple properties and only one of them is marked as a secret, we currently have to "secretify" the entire result, because most SDKs return an Output<InvokeResult> where InvokeResult is plain. However for YAML, from the consumer point of view, this is not a requirement and may be unexpected - there is no type constraint that would prevent us from returning a mixed bag. Yet, we use the Go SDK behind the scenes, so secretness of a single property contaminates the entire result in YAML.

Affected area/feature

Invokes/Functions

@mikhailshilkov mikhailshilkov added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Sep 18, 2024
@justinvp justinvp removed the needs-triage Needs attention from the triage team label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants