Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address overview pages that do not meet content requirements #5307

Open
sean1588 opened this issue Aug 29, 2024 · 3 comments
Open

Address overview pages that do not meet content requirements #5307

sean1588 opened this issue Aug 29, 2024 · 3 comments
Labels
kind/enhancement Improvements or new features
Milestone

Comments

@sean1588
Copy link
Member

We added a check to the registry to ensure the package overview page is not blank and also contains a minimal amount of content (at least 250 characters). We have added the current failing packages to an exceptions list for now in order to get the tests passing until these get addressed.

Here is a list of the current failures:

ERROR: The content in the overview file, themes/default/content/registry/packages/heroku/_index.md, does not meet the 250 character minimum requirement for content.
ERROR: The content in the overview file, themes/default/content/registry/packages/junipermist/_index.md, does not meet the 250 character minimum requirement for content.
ERROR: The content in the overview file, themes/default/content/registry/packages/meraki/_index.md, does not meet the 250 character minimum requirement for content.
ERROR: The content in the overview file, themes/default/content/registry/packages/packet/_index.md, does not meet the 250 character minimum requirement for content.
ERROR: The content in the overview file, themes/default/content/registry/packages/sdwan/_index.md, does not meet the 250 character minimum requirement for content.

We need to get heroku, junipermist, meraki, packet, and sdwan addessed.

@sean1588 sean1588 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Aug 29, 2024
@interurban interurban added p1 A bug severe enough to be the next item assigned to an engineer and removed needs-triage Needs attention from the triage team labels Sep 25, 2024
@interurban interurban modified the milestones: 0.110, 0.111 Sep 25, 2024
@interurban interurban modified the milestones: 0.111, 0.112 Oct 30, 2024
@iwahbe
Copy link
Member

iwahbe commented Nov 4, 2024

The check is here:

# TODO: Remove this line and the reference to excluded_pkgs below when https://github.com/pulumi/registry/issues/5307 is resolved.
excluded_pkgs=("heroku" "junipermist" "meraki" "packet" "sdwan")

@iwahbe iwahbe removed the p1 A bug severe enough to be the next item assigned to an engineer label Nov 4, 2024
@iwahbe
Copy link
Member

iwahbe commented Nov 4, 2024

Let's reconsider this as a P1. I'm not sure we should address this in the general case, but I'm doubly unsure this needs to be prioritized to the next item, having sat unaddressed and unassigned for 2 months.

@iwahbe
Copy link
Member

iwahbe commented Nov 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
Status: 🎬 Ready
Development

No branches or pull requests

3 participants