-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing dependency: lighthouse #334
Comments
@adamraine could you please take a look? |
So we prevent Lighthouse from being bundled using rollup externals: Line 20 in 961965e
I would expect tree shaking prevent rollup from using In any case, we should remove the lighthouse runner extension from the main bundle. Eventually we will make Lighthouse a peer dependency, but Lighthouse needs a lot of work with rollup plugins to work in bundled environments. If rollup can't automatically trim the Lighthouse import statements, maybe we should add a separate import path for Lighthouse like |
Expected Behavior
The @puppeteer/replay is compiled without errors when it is installed as a dependency.
Actual Behavior
An error occurs when I bundle my app:
This is due to lighthouse missing from the dependencies and/or peerDependencies in package.json.
lighthouse
is listed only as a devDependency, while in fact it is a normal dependency since the library source depends on it.Steps to Reproduce the Problem
import { PuppeteerRunnerExtension } from '@puppeteer/replay'
Specifications
The text was updated successfully, but these errors were encountered: