-
Notifications
You must be signed in to change notification settings - Fork 24
Support for Puppet 5 or what new helper should be used? #33
Comments
follow ups:
|
Looks like that's merged. We've been out of it for a while, but BPIH should definitely get puppet5 abilities... just in time for puppet 6 :D. This isn't deprecated... it's still the de facto interface for doing a basic puppet install for acceptance testing with minimal fuss. |
I am personally not a huge fan of BPIH because it's yet another layer on top of a lot of layers. However, BPIH does have puppet5 capabilities. The install type ( The above set up will end up calling a method defined in beaker-puppet. However, looking at this, it looks like we need to modify BPIH a bit to pass in at least @vinzent I hope that helps a bit. Please feel free to reach out if you have any questions or ping me in the puppet community slack |
Yeah! Beaker got a lot more variables since BPIH was written so BPIH variables (starting with
It was always the intention that BPIH should only ever "exist to provide the most user-friendly interface for getting puppet installed and working so that module tests can proceed" since beaker had way too many knobs or missing knobs back when it was created. It was even stated that BPIH is "definitely going away" in https://github.com/puppetlabs/beaker-puppet_install_helper/blob/master/CONTRIBUTING.md#contributing-and-adding-features . But you know what they say about temporary hacks...
I think this was deprecated because beaker's Try |
I'm not so sure, judging from the code. If you pass the type in to beaker-puppet_install_helper/lib/beaker/puppet_install_helper.rb Lines 113 to 120 in 1d0763f
edit: derp, looking at that code more closely, it'll default to agent as long as |
At VoxPupuli the beaker tests use the puppet_install_helper method.
It's not possibile to declare
PUPPET_INSTALL_VERSION=5.0.0
right now. Reading https://github.com/puppetlabs/beaker-puppet_install_helper/blob/master/CONTRIBUTING.md it seems like this is deprecated.What is the puppet beaker rspec way to test with the new Puppet 5?
The text was updated successfully, but these errors were encountered: