-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure 'ordering' for rspec-puppet in PDK #511
Comments
scotje
added
needs-triage
Newly created issue that has not been reviewed by a PDK contributor
feature
and removed
needs-triage
Newly created issue that has not been reviewed by a PDK contributor
labels
May 15, 2019
Thanks for bringing this up! This will addressed via the rspec-puppet issue you filed, at which point PDK will pick up the new behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just found after reading through documentation that Puppet and rspec-puppet handle ordering in different ways.
Currently rspec-puppet defaults to "title-hash" and Puppet 5.5 defaults to "manifest".
The difference between
and
seems significant enough to make more explicit for users writing tests. This is especially true if random ordering requires additional lines of code to avoid breaking.
It will help improve the user experience with people new to writing tests if the test tools and Puppet itself are consistent in behaviour.
https://github.com/rodjek/rspec-puppet#ordering
https://puppet.com/docs/puppet/4.6/configuration.html#ordering
https://puppet.com/docs/puppet/5.5/configuration.html#ordering
I have also logged a ticket rodjek/rspec-puppet#689 related to the default value.
Is it reasonable to have a configuration option for this?
The text was updated successfully, but these errors were encountered: