Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The facts plan should always add facts for successful nodes #50

Open
glangloi opened this issue Dec 10, 2020 · 0 comments
Open

The facts plan should always add facts for successful nodes #50

glangloi opened this issue Dec 10, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@glangloi
Copy link

Use Case

I would expect the facts plan to always add facts to the inventory for successful nodes, even if it failed on some nodes.

Describe the Solution You Would Like

The facts task should catch errors and then call add_facts for successful nodes. Then either fail the plan with the original error, or return $result_set if all succeeded. However, I could be missing an important reason for why add_facts and the facts task are independent of each other in the first place.

Describe Alternatives You've Considered

I'm currently using a wrapper plan which does the above. This lets me run facts for a bunch of nodes and at least continue on even if we failed to collect facts for some nodes.

@glangloi glangloi added the enhancement New feature or request label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant