(CONT-914) - Opt for facts over fetch_ip

Author: jordanbreen28

spec/acceptance/kubernetes_spec.rb

@@ -9,16 +9,14 @@
       context 'it should install the module and run' do
         before(:all) { change_target_host('controller') }
         after(:all) { reset_target_host }
-        # fetch_ip_hostname_by_role returns an array of 3 elements [hostname, ipaddress, internal_ipaddress]
-        int_ipaddr1 = fetch_ip_hostname_by_role('controller')[2]
 
         pp = <<-MANIFEST
         case $facts['os']['family'] {
           'RedHat', 'CentOS':  {
             class {'kubernetes':
               kubernetes_version => '1.22.0',
               kubernetes_package_version => '1.22.0',
-              controller_address => "#{int_ipaddr1}:6443",
+              controller_address => "$facts['networking'][ip']:6443",
               container_runtime => 'docker',
               manage_docker => false,
               controller => true,

spec/spec_helper_acceptance_local.rb

@@ -75,11 +75,11 @@ def configure_puppet_server(controller, worker1, worker2)
   puppet_cert_sign
   # Create site.pp
   site_pp = <<-EOS
-  node /#{controller[0]}/ {
+  node /#{controller}/ {
     class {'kubernetes':
       kubernetes_version => '1.20.6',
       kubernetes_package_version => '1.20.6',
-      controller_address => "#{controller[1]}:6443",
+      controller_address => "$facts['networking'][ip']:6443",
       container_runtime => 'docker',
       manage_docker => false,
       controller => true,
@@ -145,7 +145,7 @@ def execute_agent(role)
         ENV['TARGET_HOST'] = target_roles(node)[0][:name]
         run_shell("echo #{int_ipaddr1} puppet  >> /etc/hosts")
       }
-      configure_puppet_server([hostname1, int_ipaddr1], hostname2, hostname3)
+      configure_puppet_server(hostname1, hostname2, hostname3)
     else
       c.filter_run_excluding :integration
     end