Attempt using a reusable command in circle ci

Author: npwalker

.circleci/config.yml

@@ -1,4 +1,29 @@
-version: 2
+version: 2.1
+
+commands:
+  runspecs:
+    description: "A command for running rake spec"
+    parameters:
+      spec_command:
+        type: string
+        default: "parallel_spec"
+    steps:
+      - checkout
+      - run: bundle -v
+      - run: rm -f Gemfile.lock
+      - run: gem update --system $RUBYGEMS_VERSION
+      - run: gem --version
+      - run: bundle -v
+      - restore_cache:
+          keys:
+            - ${CIRCLE_PROJECT_REPONAME}-{{ checksum "Gemfile" }}
+            - ${CIRCLE_PROJECT_REPONAME}-
+      - run: bundle install --jobs $(nproc) --path vendor/bundle
+      - save_cache:
+          key: ${CIRCLE_PROJECT_REPONAME}-{{ checksum "Gemfile" }}
+          paths:
+            - vendor/bundle
+      - run: bundle exec rake << parameters.spec_command >>
 
 spec: &spec
     steps:
@@ -10,40 +35,47 @@ spec: &spec
       - run: bundle -v
       - restore_cache:
           keys:
-            - pe_databases-{{ checksum "Gemfile" }}
-            - pe_databases-
+            - ${CIRCLE_PROJECT_REPONAME}-{{ checksum "Gemfile" }}
+            - ${CIRCLE_PROJECT_REPONAME}-
       - run: bundle install --jobs $(nproc) --path vendor/bundle
       - save_cache:
-          key: pe_databases-{{ checksum "Gemfile" }}
+          key: ${CIRCLE_PROJECT_REPONAME}-{{ checksum "Gemfile" }}
           paths:
             - vendor/bundle
       - run: bundle exec rake $SPEC
 
 jobs:
   lint:
-    environment:
-      CHECK: "check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop syntax lint metadata_lint"
+    #environment:
+    #  CHECK: "check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop syntax lint metadata_lint"
     docker:
       - image: circleci/ruby:2.5.3
-    <<: *spec
-  parallel_spec_2.5.3:
+    steps:
+      - runspecs:
+        spec_command: "check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop syntax lint metadata_lint"
+    #<<: *spec
+  parallelspec253:
     environment:
-      SPEC: parallel_spec
       PUPPET_GEM_VERSION: "~> 6.0"
     docker:
       - image: circleci/ruby:2.5.3
-    <<: *spec
-  parallel_spec_2.4.5:
+    steps:
+      - runspecs:
+        spec_command: "parallel_spec"
+    #<<: *spec
+  parallelspec245:
     environment:
-      SPEC: parallel_spec
       PUPPET_GEM_VERSION: "~> 5.0"
     docker:
       - image: circleci/ruby:2.4.5
-    <<: *spec
+    steps:
+      - runspecs:
+        spec_command: "parallel_spec"
+    #<<: *spec
 workflows:
   version: 2
   test:
     jobs:
       - lint
-      - parallel_spec_2.5.3
-      - parallel_spec_2.4.5
+      - parallelspec253
+      - parallelspec245