Change ensure_resource(file) back to file resources

Prior to this commit, we used ensure_resource because it was meant
to be inside a defined type that may be specified more than once.
Now the defined type is gone and backup is a class

After this commit, we use file resources for clarity since the class
should not be defined more than once.

Author: npwalker

manifests/backup.pp

@@ -23,15 +23,15 @@
   String $backup_logging_directory = '/var/log/puppetlabs/pe_databases_backup',
 ) {
 
-  ensure_resource( 'file', [ '/opt/puppetlabs/pe_databases', '/opt/puppetlabs/pe_databases/scripts', $backup_directory ],
-    { 'ensure' => 'directory' }
-  )
+  file { ['/opt/puppetlabs/pe_databases', '/opt/puppetlabs/pe_databases/scripts', $backup_directory ] :
+    ensure => directory,
+  }
 
-  ensure_resource( 'file', $backup_logging_directory,
-    { 'ensure' => 'directory',
-      'owner' => 'pe-postgres',
-      'group' => 'pe-postgres', }
-  )
+  file { $backup_logging_directory :
+    ensure => 'directory',
+    owner  => 'pe-postgres',
+    group  => 'pe-postgres',
+  }
 
   file { 'puppet_enterprise_db_backup_script' :
     ensure => file,
@@ -45,7 +45,7 @@
   $databases_and_backup_schedule.each | Hash $dbs_and_schedule | {
 
     $databases_to_backup = $dbs_and_schedule['databases']
-    $db_string = join($databases_to_backup, " ")
+    $db_string = join($databases_to_backup, ' ')
 
     cron { "puppet_enterprise_database_backup_${databases_to_backup}":
       ensure  => present,