(PE-39577) Optimise legacy compiler support #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
2 times, most recently
from
4b1a560 to
b5b9ca5
Compare
ragingra
reviewed
Jan 20, 2025
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
from
b5b9ca5 to
9888996
Compare
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
13 times, most recently
from
9e5efc3 to
1431087
Compare
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
2 times, most recently
from
0cec740 to
81e986a
Compare
|
Just to note, commits will be squashed |
Sharpie
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
I tested this out with a PE 2021.7.10 -> 2023.8.2 upgrade and it resolved most issues outlined in PE-39577.
One item that still remains unresolved is:
Ensure that running
puppet infra configuredoes not remove classification rules
But, that can be split off to a separate ticket. The fix to that likely spans changes to both peadm and the puppet-enterprise-modules.
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
from
55d852f to
7c6170f
Compare
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
4 times, most recently
from
4d13520 to
90a1318
Compare
petergmurphy
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
4 times, most recently
from
7a09089 to
10634e0
Compare
davidmalloncares
approved these changes
Mar 20, 2025
davidmalloncares
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
4 times, most recently
from
e71a2f8 to
4479baf
Compare
This commit:
- Adds the `node_group_unpin` task.
- `node_group_unpin` task is called in the convert plan to remove
legacy compilers from from the PE Master node group.
- Legacy compilers `pp_auth_role` changed to `pe_compiler_legacy`.
- Changes the PEADM config to use the PE Certificate Authority node group.
- Removes peadm_legacy_compiler OID extension.
- Adds a task to update PE Master rules to support 'pe_compiler_legacy'
as a pp_auth_role.
- Adds a task to check if PE Master rules have been updated to support
the new method of legacy compiler identification.
- This task is being used in the `add_compilers` and
`convert_compiler_to_legacy` plans to check if the infrastructure
has been converted to support this new method of legacy compiler
identification. If the infrastructure has not been converted, it will
fail each plan and tell the user to run the Convert plan.
davidmalloncares
force-pushed
the
pe-39577-optimise-legacy-compiler-support
branch
from
4479baf to
146b1ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will:
node_group_unpintask.node_group_unpintask is called in the convert plan to removelegacy compilers from from the PE Master node group.
pp_auth_rolechanged tope_compiler_legacy.as a pp_auth_role.
the new method of legacy compiler identification.
add_compilersandconvert_compiler_to_legacyplans to check if the infrastructurehas been converted to support this new method of legacy compiler
identification. If the infrastructure has not been converted, it will
fail each plan and tell the user to run the Convert plan.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?