(PIE-1401) Add system cert store SSL validation #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreymbe
force-pushed
the
PIE-1401-include_system_cert_store
branch
from
c580fc9
to
9a8f00b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit changes the way certificate validation occurs. In particular, when
HTTPSis specified in the URL we first check for a provided CA certificate, then check to see if we should validate against the default system store before performing the request without verification.Detailed Description
manifests/init.ppand renamedignore_system_cert_storetoinclude_system_cert_store.templates/settings.yaml.eppwithinclude_system_cert_store.lib/puppet/util/splunk_hec.rbto take precedence for provided CA -> system store -> no verification.templates/util_splunk_hec.erbto ensure event forwarding uses the same SSL validation.spec/spec_helper_acceptance_local.rbwithinclude_system_cert_storefor spec testing.CHANGELOG.mdREADME.mdREFERENCE.mdChecklist
[X] Ensure README is updated
[X] Acceptance Tests
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title