Merge pull request #657 from HelenCampbell/dupRemoval

Remove duplicate deprecation warnings

Author: DavidS

lib/puppet/parser/functions/validate_absolute_path.rb

@@ -26,7 +26,8 @@ module Puppet::Parser::Functions
 
     ENDHEREDOC
 
-    function_deprecation([:puppet_3_type_check, 'This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Absolute_path. There is further documentation for validate_legacy function in the README.'])
+    # The deprecation function was being called twice, as validate_absolute_path calls is_absolute_path. I have removed it from here so it only calls deprecation once within is_absolute_path.
+    # function_deprecation([:puppet_3_type_check, 'This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Absolute_path. There is further documentation for validate_legacy function in the README.'])
 
     require 'puppet/util'
 

lib/puppet/parser/functions/validate_bool.rb

@@ -19,7 +19,8 @@ module Puppet::Parser::Functions
 
     ENDHEREDOC
 
-    function_deprecation([:puppet_3_type_check, 'This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README.'])
+    # The deprecation function was being called twice, as validate_bool calls is_bool. I have removed it from here so it only calls deprecation once within is_bool.
+    # function_deprecation([:puppet_3_type_check, 'This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README.'])
 
     unless args.length > 0 then
       raise Puppet::ParseError, ("validate_bool(): wrong number of arguments (#{args.length}; must be > 0)")

spec/functions/validate_absolute_path_spec.rb

@@ -7,9 +7,8 @@
 
   # Checking for deprecation warning
   it 'should display a single deprecation' do
-    # called twice because validate_absolute_path calls is_absolute_path
     ENV['STDLIB_LOG_DEPRECATIONS'] = "true"
-    scope.expects(:warning).with(includes('This method is deprecated')).twice
+    scope.expects(:warning).with(includes('This method is deprecated'))
     is_expected.to run.with_params('c:/')
   end
 

spec/functions/validate_bool_spec.rb

@@ -7,9 +7,8 @@
 
   # Checking for deprecation warning
   it 'should display a single deprecation' do
-    #called twice, because validate_bool calls is_bool
     ENV['STDLIB_LOG_DEPRECATIONS'] = "true"
-    scope.expects(:warning).with(includes('This method is deprecated')).twice
+    scope.expects(:warning).with(includes('This method is deprecated'))
     is_expected.to run.with_params(true)
   end