Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r10k puppetfile install always runs "force" mode #1265

Closed
otterz opened this issue Jan 31, 2022 · 2 comments
Closed

r10k puppetfile install always runs "force" mode #1265

otterz opened this issue Jan 31, 2022 · 2 comments

Comments

@otterz
Copy link

otterz commented Jan 31, 2022

Describe the Bug

r10k puppetfile install ... always runs in force mode, no matter if --force flag is set or not. With this all local modifications will be overwritten by r10k.

Expected Behavior

Refering to the documention, r10k should not overwrite local modifications by default, so I expect modules with local modifications to be skipped from sync.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Modify a local modul
  2. Run r10k puppetfile install --verbose=notice

Environment

  • 3.14.0 (installed via puppet gem)
  • CentOS7

Additional Context

I'm updating from 3.8.0 to 3.14.0.

After some quick debugging I guess this is the cause. @overrides.dig(:modules, :force) returns nil because the key :modules does not exists in @overrides Hash when using r10k puppetfile install. So force is nil and @force will be set to true.

@Magisus
Copy link
Collaborator

Magisus commented Feb 4, 2022

This should be resolved by #1269

@mwaggett
Copy link
Contributor

mwaggett commented Feb 7, 2022

released in 3.14.1

@mwaggett mwaggett closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants