postrun after deploying a module

[amateo]

There is a postrun option that enables running a script after deploying an environment. But this script is not run after deploying a module (not an environment).
I think it would be useful to be able to run this script after deploying a module.

[chrisongthb]

We need this feature, too. Any news here?

[packetcafe]

+1 for this feature.. it would be really handy for the postrun to run for all deployment include a single module.

[github-actions]

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

[chrisongthb]

This issue is still important to us.

[github-actions]

This issue has been marked stale because it has had no activity for 60 days. The Puppet Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

[kendall-moore]

+1 for this feature. Deploying a module is still a deployment, so there's no reason postrun shouldn't be triggered.

[packetcafe]

+1 I'm also waiting for the feature, it not stable at all!.

[Magisus]

Agreed, this should be fixed. Related jira ticket: https://tickets.puppetlabs.com/browse/RK-369

[Magisus]

The postrun command for environments will read a variable $modifiedenvs and sub in the environments being deployed. We probably want to respect this for deploy module too, but should it only supply environments that were both requested and actually had the module in question? Or all requested envs, regardless of whether they were actually updated?

[alexjfisher]

Preferably, just the environments that were updated?

[Magisus]

Cool, that makes sense to me too.

[Magisus]

If it turns out that no environments were actually updated (e.g. because none of the requested ones contained the module), do we still want to run the command at all? Or only if it does not include $modifiedenvs?

[Magisus]

I have a PR up that only runs the command if any envs actually synced modules, and populates $modifiedenvs with the changed environments, see #1190. Still working on tests but would appreciate thoughts on the approach and functionality.

[Magisus]

This has been merged, and will be released soon (in the next month), or we could do sooner if there's interest, please let us know. Also if anyone has any issues with it or needs any tweaks to the functionality.