Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date-fns and react are included as dependencies for people only using the core package #19

Closed
MatthewStanciu opened this issue Dec 11, 2023 · 1 comment · Fixed by #20

Comments

@MatthewStanciu
Copy link
Member

I recently added a lightning time clock react hook as part of a sub-package @purduehackers/time, called @purduehackers/time/react. This package requires react, @types/react, and date-fns.

I didn't think before merging and I accidentally made it so that users only using the core package @purduehackers/time now have these three dependencies added to their bundle. It's baaaad that this package now forces people to install React when they just want to convert to lightning time 😭

@MatthewStanciu
Copy link
Member Author

#20 somehow introduced hard links, which prevented it from being published to npm :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant