Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Template Files not Included #372

Open
SizzinSeal opened this issue Aug 15, 2024 · 0 comments · May be fixed by #380
Open

🐛Template Files not Included #372

SizzinSeal opened this issue Aug 15, 2024 · 0 comments · May be fixed by #380

Comments

@SizzinSeal
Copy link
Contributor

SizzinSeal commented Aug 15, 2024

Expected Behavior:

a PROS project, with IS_LIBRARY set to 1, should include all files specified in TEMPLATE_FILES regardless of whether those files are from another template

Actual Behavior:

a PROS project, with IS_LIBRARY set to 1, does not include files which are part of a template installed in the project, even if explicitly set in TEMPLATE_FILES

Steps to reproduce:

  1. Create an empty PROS project named dependency
  2. Add dependency.h file in the include directory
  3. Add dependency.h to TEMPLATE_FILES in
  4. Set IS_LIBRARY to 1
  5. Set LIBNAME to dependency
  6. Create dependency@1.0.0.zip through pros make; pros make template
  7. Run pros c fetch dependency@1.0.0.zip in the same directory as dependency@1.0.0.zip
  8. Create an empty PROS project named template
  9. Set IS_LIBRARY to 1
  10. Set LIBNAME to template
  11. Install dependency by running pros c apply dependency
  12. Delete dependency.a in the firmware directory (see Issue 🐛Header-Only Templates Include Empty Binary #373 )
  13. Add template.h to the include directory
  14. add template.h and dependency.h to TEMPLATE_FILES
  15. create template@1.0.0.zip through pros make; pros make template
  16. Run pros c fetch dependency@1.0.0.zip in the same directory as dependency@1.0.0.zip
  17. Extract the zip file
  18. Observe dependency.h is not in the include directory

System information:

Windows 11: Bug Reproduced
Linux (Ubuntu): Can't reproduce
macOS: Not Tested

PROS Version: 3.5.4

Additional Information

exclude_files = exclude_files.union(project.list_template_files())
seems to be where the files are excluded in the PROS CLI

@BennyBot BennyBot linked a pull request Oct 24, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant