Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Use one-click approach for latest version numbers in welcome view #223

Closed
BennyBot opened this issue May 19, 2024 · 0 comments · Fixed by #225
Closed

✨Use one-click approach for latest version numbers in welcome view #223

BennyBot opened this issue May 19, 2024 · 0 comments · Fixed by #225
Labels
enhancement New feature or request good first issue Good for newcomers p:low Low Priority

Comments

@BennyBot
Copy link
Member

Requested Feature

Currently, the latest CLI version for welcome view is fetched by checking mainline’s upgrademanifest.json for latest release. This is annoying as we have to manually update upgrademanifest for every CLI update. This could be automated with some CI work, but the file currently is not useful besides the welcome view afaik.

Since we tag all releases, we can simply do what one-click does to find the latest versions. Get the latest release json from api.github and then just read the tag_name field.

An older method for kernel is also still present but unused in the code to use the cli to identify the latest kernel version, so this should be removed.

Benefits of Feature

Simpler code, we dont have to touch upgrademanifest again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers p:low Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant