Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile dependencies prior to running test suite #47

Closed
felixSchl opened this issue Oct 18, 2018 · 0 comments
Closed

Compile dependencies prior to running test suite #47

felixSchl opened this issue Oct 18, 2018 · 0 comments
Labels
easy good first issue Good for newcomers

Comments

@felixSchl
Copy link
Collaborator

Also see #12

We vendored the tests that come with the purescript compiler (for now). These tests are discovered, built, and executed in https://github.com/pure-c/pure-c/blob/c578687bff74370b92bdf95976b38c8adcc7b10d/test/Main.purs#L31-L59.

All tests use this makefile that is generated exactly once per pulp test:

https://github.com/pure-c/pure-c/blob/c578687bff74370b92bdf95976b38c8adcc7b10d/test/Main.purs#L61-L83

This means that all tests share the same build directory and thus can re-use shared build artifacts. Hence, the first build to run will take the longest, has it has to build a lot of the dependencies that are required. This will usually time out.

Instead, we should create a dummy target (or choose a test we consider infallible) that is built prior the actual tests running.

@felixSchl felixSchl added good first issue Good for newcomers easy labels Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant