You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
because lib.version is now (as of commit a6975e9 I think) evaluated after cflags are passed to c.flags, it doesn't make it into c.flags that rely on it (such as -DVERSION in zexy)
(I wrote a comment in the commit but not sure if anyone would see it)
The text was updated successfully, but these errors were encountered:
it seems that a fix is to move the variables: library name and version section to the top of the Makefile (i put it right after Makefile.pdlibbuilder = true and the target platform detection.
this is probably a safe place, as i think that these variables are "static" (as in: not hacked upon by pd-lib-builder users), and they are expanded simply (as in non-recursively) anyhow.
there's probably an even better place, i haven't looked far.
@katjav i guess the "nice structure" of the Makefile.pdlibbuilder needs to be re-evaluated.
probably it is enough to split into a first part that only deals with simply expanded variables, and a 2nd part to deal with recursively expanded vars.
This solves the issue where platform-dependent class inclusion
could not work (#61). Also it seems a more logical order of
evaluation in general because binary file extensions are platform-
dependent.
because lib.version is now (as of commit a6975e9 I think) evaluated after cflags are passed to c.flags, it doesn't make it into c.flags that rely on it (such as -DVERSION in zexy)
(I wrote a comment in the commit but not sure if anyone would see it)
The text was updated successfully, but these errors were encountered: