Closing vimspector tab can raise error or close wrong tab

[alps2006]

Description

Debugger quit exceptionally when closing a new tab that inserted before vimspector tab.

I found that vimspector session can be queried by tabpagenr in neovim, but that inserting a new tab can lead tabpagenr changed.

Works in vim?

Only broken in Neovim

Works with clean config?

Yes

Sample project works?

Reproducable with sample project

Minimal Reproduction

List of steps to reproduce:

1. Launch a debugger.
2. Run a command tabpagenr()-1 tabnew
3. Close the new tab.

Expected Behaviour

Debugger don't quit.

Actual Behaviour

Debugger quit.

Additional information

No response

Installation Type

Plugin Manager (git clone)

Vimspector version

latest

Debug Info

No response

Log file

No response

Vim version

nvim 8.x

Python version

No response

Neovim diagnostics

No response

Operating System

No response

Declaration

• I have read and understood CONTRIBUTING.md
• I have read and understood the CODE_OF_CONDUCT.md

[alps2006]

The snippet in

vimspector/autoload/vimspector/internal/state.vim

Line 107 in 6d818bb

s = _vimspector_session_man.FindSessionByTab( int( vim.eval( 'a:afile' ) ) )

[puremourning]

Thanks for the report.

I'm not sure this is fixable because neovim... neovim/neovim#16327. Feel free to badger them to fix this - it's the only way.

It seems that although tabs aren't correctly invalidated, their tab numbers are updated before TabClosed is called, so there's no way for Vimspector to know that you closed a tab which wasn't the vimspector tab but is now.

[puremourning]

I think this actually broken in Vim too, but in a different (worse?) way. I think we end up closing the wrong tab sometimes :(