-
Notifications
You must be signed in to change notification settings - Fork 65
Smarter Monoid
instance for ReactElement
#157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think we should try and get this in for the upcoming breaking release for PureScript 0.14. |
We may not be able to get this in for 0.14 due to a backlog of other work, so I'm going to remove the label. |
Fixed by #187 |
To be clear, I only changed it so that mempty is null and it avoids creating redundant fragments if one of the elements is also null. There isn't a reliable way of always flattening to an Array in |
React still sometimes has trouble with
[]
as mempty if you are returning it from a render method. We should usenull
asmempty
. Additionally, we should make a smarterappend
that does not build nested fragments, but instead concatenates Arrays.The text was updated successfully, but these errors were encountered: