Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Aff not implement MonadST? #50

Closed
prescientmoon opened this issue Aug 2, 2022 · 7 comments
Closed

Why does Aff not implement MonadST? #50

prescientmoon opened this issue Aug 2, 2022 · 7 comments

Comments

@prescientmoon
Copy link

Is there any particular reason for this? In particular, purescript-hyrule bases a lot of the helpers around MonadST, so it would be nice to be able to use them directly with Aff

@garyb
Copy link
Member

garyb commented Aug 2, 2022

Moving question to Aff since that's where the instance would live 🙂

@garyb
Copy link
Member

garyb commented Aug 2, 2022

Okay, nevermind. You can't move issues cross-organization.

@natefaubion
Copy link

I think it's just that MonadST is relatively new and no one has asked for it.

@prescientmoon
Copy link
Author

If I'd open a PR for it, would it get merged? If yes, I should open it on the Aff repo, right?

@JordanMartinez
Copy link
Contributor

I'd say yeah?

@JordanMartinez
Copy link
Contributor

I'm guessing the instance would just be lifting the Effect instance, right? Something like this?

instance MonadST s Aff where
  liftST = liftEffect <<< liftST

@prescientmoon
Copy link
Author

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants