Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spago doesn't like development versions of purs #116

Closed
btrepp opened this issue Feb 25, 2019 · 2 comments
Closed

spago doesn't like development versions of purs #116

btrepp opened this issue Feb 25, 2019 · 2 comments

Comments

@btrepp
Copy link
Contributor

btrepp commented Feb 25, 2019

So I grabbed purs 0.12.3 and stack installed it (no windows release it seems).

spago install gives

spago: Failed to parse 'purs --version' output:
"0.12.3 [development build; commit: b35412a9ea49a46d315a0214cd2c3908442ab7a7]
"

Might be nice if there is some sort of flag/escape hatch for "It may not be compatible but I know what I'm doing"

@f-f
Copy link
Member

f-f commented Feb 25, 2019

@btrepp fix should be up in #117, could you try it?

Re having a "general escape hatch": it's hard to propagate this kind of thing all over the place, as the failure modes are different. E.g. in this case we could log a warning and return a Maybe instead of failing, and then propagate the general handling around the rest of the program that needs it (in this case in the package-set version check). Though this fix should be good enough to support all the versions we might get

@f-f
Copy link
Member

f-f commented Feb 25, 2019

Update: now we don't fail if parsing fails, but just leave a warning

@f-f f-f closed this as completed in #117 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants