-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should spago sources
include sources in spago.dhall?
#287
Comments
When #273 went in I started wondering about the fact that the project sources are not returned by So yes, I'd say we should use the Btw I think you can incrementally improve on your current solution by exploiting Dhall's native support for JSON which just got merged to the Prelude: i.e. if it's ok for you to depend on the |
Yeah, having the compiler ignore repeated source files would definitely help. So add the flag for now, and then wait until purescript/purescript#3653 is fixed and released to make --with-local the default? That sounds good to me yeah :) |
Update: since v0.13.2 is out with the fix for purescript/purescript#3653 it looks like we can even skip the flag and just add the project sources here 🎉 |
Possibly related to #276.
We have nonstandard
sources
in some of ourspago.dhall
files, and we want to usepscid
in our projects. At the moment we have something along the lines of this in ourpackage.json
file:so that
sources:purs
prints out a list of globs,sources:purs:directories
strips the trailing**/*.purs
, and then we usetr
to join all of those directories together with;
and pass that topscid
, becausepscid
expects a list of directory names (not globs) separated by;
.I would quite like to get rid of the
sources:purs
script and have this list of directories stored in thesources
key of ourspago.dhall
files, but I wasn't able to come up with an easy way of getting this information out ofspago.dhall
without involvingjq
anddhall-to-json
.If
spago sources
could include any extra sources listed inspago.dhall
this would be fairly straightforward to achieve. Perhaps it would make sense to include these only if a--with-local
flag is passed or something, so as not to be a breaking change?The text was updated successfully, but these errors were encountered: