Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small package.dhall docs improvement #408

Closed
alextes opened this issue Sep 12, 2019 · 1 comment · Fixed by #413
Closed

Small package.dhall docs improvement #408

alextes opened this issue Sep 12, 2019 · 1 comment · Fixed by #413

Comments

@alextes
Copy link
Contributor

alextes commented Sep 12, 2019

In the template, specifically this line, the example shows "package-name" by which it appears to mean a package name but without the ". In other words, the package name should be a label, not a string, as the example shows. This is confusing however, as the documentation naturally also uses " to indicate you should use a string.

The proposal would be to remove the " for the label. Am I making sense? 😄

Thanks for an awesome tool 🙌 !

@f-f
Copy link
Member

f-f commented Sep 15, 2019

@alextes thanks 🙂 And indeed you're right, they should be labels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants