Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spago upstream command #72

Closed
f-f opened this issue Jan 14, 2019 · 5 comments
Closed

spago upstream command #72

f-f opened this issue Jan 14, 2019 · 5 comments

Comments

@f-f
Copy link
Member

f-f commented Jan 14, 2019

It is usual to add packages that are not in the package-set to the packages.dhall (I mean, this is basically our main feature). It would be nice to have an easy way to have them contributed to the upstream package-set, e.g. with something like spago upstream whatever-package.

What this command would do is:

  • check that the package is not in the upstream package-set (if it is, prompt the user to upgrade)
  • if it's not, open a pull request to spacchetti (e.g. with this) (note: we'll need to think of a way to handle auth. I guess passing a github token with a flag could be ok?)
@f-f
Copy link
Member Author

f-f commented Jan 14, 2019

I guess this is kind of a deal-breaker though (from Github docs):
image

@JordanMartinez
Copy link
Contributor

This is also listed as a preview features, so that condition might drop in the future.

@f-f
Copy link
Member Author

f-f commented Jan 15, 2019

Yeah, though the problem of authentication still stands (you have to be authenticated AND to have a fork of spacchetti in your account, which is unlikely).

Instead it would probably work better to just:

  1. print out a bunch of information about how much our package set is not in sync with our current one (additions, version upgrades, different upstream), and
  2. print out a URL to automatically open an issue, prepopulated with useful info for us (so we can just copypaste it into a PR for spacchetti, or have @spacchettibotti open PRs for us), like: https://github.com/spacchetti/spacchetti/issues/new?title=Spago+Upstream+Request&body=blabla

@f-f
Copy link
Member Author

f-f commented Jan 29, 2019

This together with #89 would be the "publishing flow": we could include a spago publish command that does the spago upstream of the current package. We would need to require a git url to be in the spago.dhall, and if we require it to be a GitHub repo we could search for releases and pick the most recent.

@f-f f-f added this to the 1.0 milestone Feb 6, 2019
@f-f f-f changed the title spago spacchetti-upstream command spago upstream command Feb 28, 2019
@f-f f-f mentioned this issue May 16, 2019
@f-f f-f removed this from the 1.0 milestone Nov 11, 2019
@f-f
Copy link
Member Author

f-f commented Feb 1, 2020

I'm going to close this as it looks like this is not something that we clearly want. I suspect something along the lines of this command might pop up when designing the new registry, but I think we can archive this for now.

@f-f f-f closed this as completed Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants