Skip to content

Commit 5046be4

Browse files
committed
examples/features/csm_observability: use helloworld client and server instead of echo client and server (grpc#7945)
1 parent 1feee8f commit 5046be4

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

examples/features/csm_observability/client/main.go

+7-4
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030
"google.golang.org/grpc"
3131
"google.golang.org/grpc/credentials/insecure"
3232
xdscreds "google.golang.org/grpc/credentials/xds"
33-
"google.golang.org/grpc/examples/features/proto/echo"
33+
pb "google.golang.org/grpc/examples/helloworld/helloworld"
3434
"google.golang.org/grpc/stats/opentelemetry"
3535
"google.golang.org/grpc/stats/opentelemetry/csm"
3636
_ "google.golang.org/grpc/xds" // To install the xds resolvers and balancers.
@@ -40,9 +40,12 @@ import (
4040
"go.opentelemetry.io/otel/sdk/metric"
4141
)
4242

43+
const defaultName = "world"
44+
4345
var (
4446
target = flag.String("target", "xds:///helloworld:50051", "the server address to connect to")
4547
prometheusEndpoint = flag.String("prometheus_endpoint", ":9464", "the Prometheus exporter endpoint")
48+
name = flag.String("name", defaultName, "Name to greet")
4649
)
4750

4851
func main() {
@@ -68,15 +71,15 @@ func main() {
6871
log.Fatalf("Failed to start NewClient: %v", err)
6972
}
7073
defer cc.Close()
71-
c := echo.NewEchoClient(cc)
74+
c := pb.NewGreeterClient(cc)
7275

7376
// Make an RPC every second. This should trigger telemetry to be emitted from
7477
// the client and the server.
7578
for {
7679
ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
77-
r, err := c.UnaryEcho(ctx, &echo.EchoRequest{Message: "this is examples/opentelemetry"})
80+
r, err := c.SayHello(ctx, &pb.HelloRequest{Name: *name})
7881
if err != nil {
79-
log.Printf("UnaryEcho failed: %v", err)
82+
log.Fatalf("Could not greet: %v", err)
8083
}
8184
fmt.Println(r)
8285
time.Sleep(time.Second)

examples/features/csm_observability/server/main.go

+8-7
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,14 @@ package main
2222
import (
2323
"context"
2424
"flag"
25-
"fmt"
2625
"log"
2726
"net"
2827
"net/http"
2928

3029
"google.golang.org/grpc"
3130
"google.golang.org/grpc/credentials/insecure"
3231
xdscreds "google.golang.org/grpc/credentials/xds"
33-
pb "google.golang.org/grpc/examples/features/proto/echo"
32+
pb "google.golang.org/grpc/examples/helloworld/helloworld"
3433
"google.golang.org/grpc/stats/opentelemetry"
3534
"google.golang.org/grpc/stats/opentelemetry/csm"
3635
"google.golang.org/grpc/xds"
@@ -45,13 +44,15 @@ var (
4544
prometheusEndpoint = flag.String("prometheus_endpoint", ":9464", "the Prometheus exporter endpoint")
4645
)
4746

48-
type echoServer struct {
49-
pb.UnimplementedEchoServer
47+
// server is used to implement helloworld.GreeterServer.
48+
type server struct {
49+
pb.UnimplementedGreeterServer
5050
addr string
5151
}
5252

53-
func (s *echoServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.EchoResponse, error) {
54-
return &pb.EchoResponse{Message: fmt.Sprintf("%s (from %s)", req.Message, s.addr)}, nil
53+
// SayHello implements helloworld.GreeterServer
54+
func (s *server) SayHello(_ context.Context, in *pb.HelloRequest) (*pb.HelloReply, error) {
55+
return &pb.HelloReply{Message: "Hello " + in.GetName()}, nil
5556
}
5657

5758
func main() {
@@ -80,7 +81,7 @@ func main() {
8081
if err != nil {
8182
log.Fatalf("Failed to start xDS Server: %v", err)
8283
}
83-
pb.RegisterEchoServer(s, &echoServer{addr: ":" + *port})
84+
pb.RegisterGreeterServer(s, &server{addr: ":" + *port})
8485

8586
log.Printf("Serving on %s\n", *port)
8687

0 commit comments

Comments
 (0)