Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: allowed list command line args added via objcopy ? #14

Open
smoser opened this issue Mar 18, 2022 · 1 comment
Open

RFC: allowed list command line args added via objcopy ? #14

smoser opened this issue Mar 18, 2022 · 1 comment

Comments

@smoser
Copy link
Contributor

smoser commented Mar 18, 2022

Maybe this is an example of seeing everything as a nail since we have a big hammer in objcopy.

I added support for stubby to use an 'allowed list' of command line arguments .
I occurs to me that that is a thing that might likely be changed (as it is, there is 'root=atomix' allowed, which is clearly not general purpose).

Should we allow putting that white list into the stubby.efi via objcopy? Then whoever is putting together a kernel/initrd can make the decision of what is acceptable. Ultimately, the list is signed by the signer, so its up to them what they want to do anyway.

I am somewhat weary of this running amuck into a general purpose "stuff configuration into stubby.efi" mechanism.

Thoughts?
Scott

@hallyn
Copy link
Contributor

hallyn commented Sep 29, 2022

I'm good with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants