Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in component sum equations for GHI, DHI, and DNI into the pvlib.irradiance module. #1565

Closed
kperrynrel opened this issue Oct 3, 2022 · 1 comment · Fixed by #1567
Closed
Milestone

Comments

@kperrynrel
Copy link
Member

Right now, we have code for calculating GHI, DHI, and DNI via the component sum equations in pvlib/pvanalytics, and doing nighttime corrections (pvlib/pvanalytics#163). @cwhanse and @kanderso-nrel suggested we port over the 3 component sum equations to the pvlib.irradiance module, and call them directly in pvlib/pvanalytics before applying a nighttime filter. This would require taking the guts out of pvlib.modelchain.ModelChain._complete_irradiance and creating a new function in pvlib.irradiance.

@cwhanse
Copy link
Member

cwhanse commented Oct 3, 2022

Said differently: we're proposing to promote the ModelChain method _complete_irradiance to a public function in pvlib.irradiance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants