Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvlib.soiling.hsu does not require rain_accum_period to be a Timedelta #1711

Open
williamhobbs opened this issue Apr 6, 2023 · 0 comments
Open

Comments

@williamhobbs
Copy link
Contributor

Describe the bug
If a user accidentally passes rain_accum_period in pvlib.soiling.hsu as an integer, the function runs without error. Is that desired? I'm concerned that someone could test with hour interval data, in which case rain_accum_period = 1 and rain_accum_period = pd.Timedelta('1h') will give the same results. But, if they later switch to using, e.g., 15-min interval data, rain_accum_period = 1 may give unintended results.

Expected behavior
Either an error for using integers, or clarification in the function's documentation that integers will work but they specify number of intervals instead of number of hours.

Tagging @andrewtrendline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant