Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify or remove assert_*_equal wrappers around pandas.testing functions #2263

Open
kandersolar opened this issue Oct 16, 2024 · 1 comment
Labels

Comments

@kandersolar
Copy link
Member

We have our own wrappers in conftest.py for the three pandas assert_X_equal functions. We originally added those because the default tolerances of those functions changed in pandas 1.1.0 (see #1018). Our wrappers check the version of pandas and do some simple kwarg manipulation based on whether the installed pandas is greater or lower than 1.1.0.

Now that our minimum pandas is greater than 1.1.0, the version checking is no longer needed and we can simplify those functions.

It is also worth looking into whether we can/should get rid of those wrappers entirely and just use the pandas functions directly, but that change might require a lot of work (#1018 (comment)).

@AdamRJensen
Copy link
Member

I think we should just get rid of our own wrappers, and use pandas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants